fix: add --clobber to release-github-assets script #4628
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✨ Coder.com for PR #4628 deployed! It will be updated on every commit.
|
Codecov Report
@@ Coverage Diff @@
## main #4628 +/- ##
=======================================
Coverage 66.10% 66.10%
=======================================
Files 30 30
Lines 1658 1658
Branches 337 337
=======================================
Hits 1096 1096
Misses 477 477
Partials 85 85 Continue to review full report at Codecov.
|
code-asher
approved these changes
Dec 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes our
release-github-assetsscript. Now if you run it twice, it will overwrite the assets uploaded to a release draft (which is the behavior I believe it previously had).This is okay to do since the script is run by a developer prepping a release and it is unlikely you would accidentally run this script twice without wanting to overwrite uploaded assets.
Fixes #4602